Skip to content

feat(sdk-coin-sol): validate v1 transaction signatures on broadcast - #9852

Merged
bhavidhingra merged 4 commits into
masterfrom
bhavi/chalo-1602-sol-v1-validation-serializer
Sep 29, 2026
Merged

bhavidhingra merged 4 commits into
masterfrom
bhavi/chalo-1602-sol-v1-validation-serializer

Conversation

@bhavidhingra

Copy link
Copy Markdown
Contributor

Gives v1 (SIMD-0296/0385) Solana transactions the same broadcast-time validation as legacy/v0: structural decode + require-all-signatures + ed25519 signature verification, instead of the current size-only check.

Changes

  • serialization/codecs/v1/message.ts: add decodeV1Message - structural v1 message decoder (version 0x81, header, config mask, blockhash, static accounts, config values, instructions) with bounds-safe truncation errors.
  • serialization/parseWireTransaction.ts (new): parseWireTransaction (splits message vs tail signatures, enforces 4096-byte v1 limit) + verifyV1Signatures + validateRawTransactionV1 (ed25519 verify each sig over messageBytes).
  • sol.ts: v1 branch of broadcastTransaction now calls validateRawTransactionV1 after the size check, matching the legacy validateRawTransaction(raw, true, true) parity.
  • Tests: decoder round-trip + rejection cases; parser split/tamper/missing-sig; broadcast valid-v1 passes, tampered-sig rejects before any node call.

Refs: CHALO-1602

@bhavidhingra
bhavidhingra requested a review from a team as a code owner September 29, 2026 11:41
@linear-code

linear-code Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

CHALO-1602

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@bhavidhingra
bhavidhingra merged commit cabde39 into master Sep 29, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants